search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

NodeManager::setBootNodes should be public #1171

Closed matthewleon closed 5 years ago

matthewleon commented 6 years ago

org.ethereum.net.rlpx.discover.NodeManager::setBootNodes should be public and not package-private. Without setting boot nodes, the object is very difficult to use outside of the package.

https://github.com/ethereum/ethereumj/blob/5c808c1ddfd743e668386d94ec68b6ba3f7713dd/ethereumj-core/src/main/java/org/ethereum/net/rlpx/discover/NodeManager.java#L120

netwalker2000 commented 5 years ago

I'v got this problem too. Without setting boot nodes, the object is very difficult to use outside of the package, considering the constructor is also public. I created a PR https://github.com/ethereum/ethereumj/pull/1262