search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

UDPListener should provide a constructor that sets this.stats #1172

Open matthewleon opened 6 years ago

matthewleon commented 6 years ago

A single line in the org.ethereum.net.rlpx.discover.UDPListener source will cause an NPE if the class is constructed outside of a Spring IOC container: https://github.com/ethereum/ethereumj/blob/5c808c1ddfd743e668386d94ec68b6ba3f7713dd/ethereumj-core/src/main/java/org/ethereum/net/rlpx/discover/UDPListener.java#L129

This was added in a single commit: https://github.com/ethereum/ethereumj/commit/2d4d6a1a823cdfb72922094990817de7eff51882

Some mechanism, either a new constructor or a setter, should be made available to initialize this.stats outside of Spring IOC.