EIP-1014 Skinny CREATE2

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.1k forks source link

EIP-1014 Skinny CREATE2 #1178

Closed zilm13 closed 5 years ago

zilm13 commented 6 years ago

Few things not yet finished, do not merge until resolved:

1 of 111 test failed both in StateTests and BlockStateTests (same), still finding out the reason
Do we need to extendTransaction#getContractAddress() for CREATE2? It's not straightforward, code need to be partially executed for this.

coveralls commented 6 years ago

Coverage decreased (-0.02%) to 56.6% when pulling de78e42168470a9d688d198163b2d99a4c37e3be on feature/eip-1014 into 10afc142e18df7b12670b85e210754aaaf2a6800 on develop.

zilm13 commented 5 years ago

@mkalinin I think we could merge it and move the tests later alone