search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

Issue-1184: no distinction between uint and int #1187

Closed jondoe1337 closed 5 years ago

jondoe1337 commented 5 years ago

During regression testing the org.ethereum.util.StandaloneBlockchainTest.encodeTest1() failed because the assumption on the expected value was wrong, imho:

The written SolidityContract has a setter-alike function and the value that is set is tested. However the value is an unsigned-int, so i doubt that the expected value -1 was correct due to the wrong uint implementation, but feel free to clear my mind.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.1%) to 56.628% when pulling 196e0a74acc1eb72ef1d217bb8371b1f63648f37 on eth-events:fix/1184-no-distinction-between-uint-and-int into 78b4b27e194cc30c5882824c609d1f28a9f74a12 on ethereum:develop.

zilm13 commented 5 years ago

@jondoe1337 cool, thank you! Will merge after test finished