Verify attestations in blocks - Githubissues

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.1k forks source link

Verify attestations in blocks #1193

Closed mkalinin closed 5 years ago

mkalinin commented 5 years ago

Abstract

Verify block's attestation records on before the import.

Proposed implementation

Implement a couple of new ValidationRule and add it to the BeaconValidator. Rules should do following checks:

Attestation record with 0 index contains distinct valid attestation that is created by proposer of that block
Attestation records with indices > 0 are valid records and were created by attesters from committee that is eligible to attest on block's slot number

Consider block as invalid if any of these two checks fails.

zilm13 commented 5 years ago

resolved with #1219