search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

Update gradle command #1198

Closed ashishb closed 5 years ago

ashishb commented 5 years ago

Replace compile with implementation as recommended here: https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.004%) to 56.485% when pulling ff10bc297795be2f6b473d9653c652544bb5c1a2 on ashishb:develop into 1b9cb0018333864ecba4082c988601deb7026a26 on ethereum:develop.

mkalinin commented 5 years ago

This change makes sense in case if we use java-library plugin

ashishb commented 5 years ago

What's the plan to use that? Afaik, "compile" is deprecated in Gradle.

mkalinin commented 5 years ago

You know, maybe I was too fast with the decision.

mkalinin commented 5 years ago

Thx 👍