Fix issue-1216: wrong signature generated for multidimensional arrays

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.1k forks source link

Fix issue-1216: wrong signature generated for multidimensional arrays #1221

Closed jondoe1337 closed 5 years ago

coveralls commented 5 years ago

Coverage increased (+0.1%) to 56.815% when pulling 24012e47b56b8638e0d1a9c239b1a32e7b7944ff on eth-events:develop into 3ae595ffca9b4a1faab221b8fdd967739d0139e2 on ethereum:develop.

Nashatyrev commented 5 years ago

Thanks a lot for doing the fix PR! I would avoid using String.indexOf tweaks where strict logic is applicable. What do you think about this fix variant https://github.com/ethereum/ethereumj/commit/baaccf744e804dc8be9808f7d6cd91f5046bfad0 ?

jondoe1337 commented 5 years ago

Looks better.

Nashatyrev commented 5 years ago

You may change you PR then and I will merge