search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.1k forks source link

No verifies the signature against the Transacton? #1223

Open quan420 opened 5 years ago

quan420 commented 5 years ago

I can't find any Verifies the ECDSA signature against the Transacton in ethereumj. Should ECKey.verify be call in Transaction.validate or some other flows?

And in go-ethereum there are ecdsa signature validate of the transaction : func (pool TxPool) validateTx(tx types.Transaction) (e error) {

from, err := types.Sender(pool.signer, tx)
if err != nil {
    e = ErrInvalidSender
    return
}
mkalinin commented 5 years ago

Isn't it a check that you're looking for? https://github.com/ethereum/ethereumj/blob/561582b965648f8d359b50d4c40c0984e5a4d48e/ethereumj-core/src/main/java/org/ethereum/core/TransactionExecutor.java#L187-L190