Improve ReceiptsDownloader: replace timeout with request counter - 1099

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.1k forks source link

Improve ReceiptsDownloader: replace timeout with request counter - 1099 #1227

Closed JonathanScialpi closed 4 years ago

JonathanScialpi commented 5 years ago

I reviewed issue 1099 and noticed the need to make the thread pause more efficient by removing the set 5 secs and replacing it with a dynamic wait time based on blocks to download.

I wanted to run some tests to verify that my change is working (besides the build) but noticed that all tests in ShortSync are failing unless I am doing something wrong. If so maybe someone can give me walkthrough on how to test properly?

coveralls commented 5 years ago

Coverage decreased (-0.03%) to 56.76% when pulling ec91a80b1a86abbb1ec82541d963da98429910c7 on JonathanScialpi:receipts_downloader into 561582b965648f8d359b50d4c40c0984e5a4d48e on ethereum:develop.

mkalinin commented 5 years ago

Looks like this change doesn't address https://github.com/ethereum/ethereumj/issues/1099. The problem might be in the issue description which is not self-explanatory. I added more details in this comment https://github.com/ethereum/ethereumj/issues/1099#issuecomment-437345292