`org.ethereum.net.rlpx.discover.NodeManager::setBootNodes` should be …

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.09k forks source link

`org.ethereum.net.rlpx.discover.NodeManager::setBootNodes` should be … #1262

Closed netwalker2000 closed 5 years ago

netwalker2000 commented 5 years ago

…public and not package-private. Without setting boot nodes, the object is very difficult to use outside of the package.

netwalker2000 commented 5 years ago

from issue https://github.com/ethereum/ethereumj/issues/1171

coveralls commented 5 years ago

Coverage increased (+0.1%) to 57.027% when pulling ca12ef2b1d0092a4b6c1bc00cd588e4c9c5cca99 on netwalker2000:develop into 580362c562eedb2d77a36935188c9aea047744ec on ethereum:develop.

mkalinin commented 5 years ago

Thanks 👍

netwalker2000 commented 5 years ago

I'm hornored :)