unused line of code? - Githubissues

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.09k forks source link

unused line of code? #1263

Open kant111 opened 5 years ago

kant111 commented 5 years ago

I was trying to see if Block Miner runs an independent separate thread with a time period or is there something that triggers a mining? Meanwhile, I found the code below where I think it is unused unless there is some spring framework magic that I am unaware of?

https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/mine/BlockMiner.java#L53

mkalinin commented 5 years ago

Yep, as far as I can see this executor is not used in any part of the codebase.

kant111 commented 5 years ago

@mkalinin should I just remove this line and send a PR? Also can you please point where the independent thread for mining gets created? Thanks.