search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.09k forks source link

Feature/solc 0.5.x #1274

Closed derekzuk closed 5 years ago

derekzuk commented 5 years ago

Unit test fixes for solc-0.5.x for ABITest, CompilerTest, and StandaloneBlockchainTest

derekzuk commented 5 years ago

This commit only contains fixes for three Test classes, so there are still outstanding failures. My intention is to make commits incrementally so that other developers do not double up on fixing the same unit tests.

1314 tests completed, 22 failed, 111 skipped

mkalinin commented 5 years ago

@derekzuk

22 failed

do all of them contain hardcoded contracts?

derekzuk commented 5 years ago

@derekzuk

22 failed

do all of them contain hardcoded contracts?

Most if not all of the test failures appear to be related to hard coded contracts in the unit tests.