search

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony
GNU Lesser General Public License v3.0
2.18k stars 1.09k forks source link

Jsontestsuite failed to execute in Windows #1277

Open oracle3 opened 5 years ago

oracle3 commented 5 years ago

in function org.ethereum.jsontestsuite.suite.JSONReader.listJsonBlobsForTreeSha(String, String) old code：

                    jsons.add(
                            f.replace(path + System.getProperty("file.separator"), "")
                             .replaceAll(System.getProperty("file.separator"), "/"));

should change to：

                    jsons.add(
                            f.replace(path + System.getProperty("file.separator"), "")
                             .replaceAll(Matcher.quoteReplacement(System.getProperty("file.separator")), "/"));
mkalinin commented 5 years ago

Hm, got your point. Would you mind creating a PR with this change?

oracle3 commented 5 years ago

how to creating a PR？