few optimizations on pruning

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.09k forks source link

few optimizations on pruning #1278

Open AbdelStark opened 5 years ago

AbdelStark commented 5 years ago

add final modifier when appropriate for method parameters
add final modifier when appropriate for class fields
add final modifier when appropriate for class
optimize HashUtil.shortHash()
use forEach instead of loop to have more consistency in the class

AbdelStark commented 5 years ago

@mkalinin can you review it please ?

coveralls commented 5 years ago

Coverage increased (+0.1%) to 57.674% when pulling dd7036295b2503d5ae02b1c0d6c28934f52e250e on abdelhamidbakhta:feature/pruning into 7a816c100df808826ba29dc053580ddee833bfe1 on ethereum:develop.