Fix MIN_GAS_LIMIT constant.

ethereum / ethereumj

DEPRECATED! Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony

GNU Lesser General Public License v3.0

2.18k stars 1.1k forks source link

Fix MIN_GAS_LIMIT constant. #1282

Closed feiqihang closed 5 years ago

feiqihang commented 5 years ago

Correct the MIN_GAS_LIMIT constant according to the Yellow Paper. Otherwise, it may cause ethereumj to be incompatible with other language implementations.

coveralls commented 5 years ago

Coverage increased (+0.004%) to 57.559% when pulling ceb0b896cf7c4fa74600a64274799515ca1c184b on feiqihang:patch-1 into 633c109b1ccb242cb14d0f8b077568ebf217d8fd on ethereum:develop.

zilm13 commented 5 years ago

@feiqihang It's not a mistake, minimum gas limit depends on network configuration. For Frontier and its children it's set to 5000: https://github.com/ethereum/ethereumj/blob/develop/ethereumj-core/src/main/java/org/ethereum/config/blockchain/FrontierConfig.java#L44-L47