ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
864 stars 286 forks source link

test: Add a state test reaching CALL max depth #1007

Open chfast opened 2 months ago

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.90%. Comparing base (1004496) to head (69b3c35).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1007 +/- ## ======================================= Coverage 93.89% 93.90% ======================================= Files 147 147 Lines 15507 15519 +12 ======================================= + Hits 14561 14573 +12 Misses 946 946 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [eof_execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `17.48% <0.00%> (-0.02%)` | :arrow_down: | | [ethereum_tests](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `27.70% <0.00%> (-0.03%)` | :arrow_down: | | [ethereum_tests_silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.41% <0.00%> (-0.02%)` | :arrow_down: | | [execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `18.98% <0.00%> (-0.02%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/1007/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `89.01% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/ethereum/evmone/pull/1007?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/unittests/state\_transition.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/1007?src=pr&el=tree&filepath=test%2Funittests%2Fstate_transition.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvc3RhdGVfdHJhbnNpdGlvbi5jcHA=) | `97.58% <100.00%> (ø)` | | | [test/unittests/state\_transition\_call\_test.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/1007?src=pr&el=tree&filepath=test%2Funittests%2Fstate_transition_call_test.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvc3RhdGVfdHJhbnNpdGlvbl9jYWxsX3Rlc3QuY3Bw) | `100.00% <100.00%> (ø)` | |
pdobacz commented 2 months ago

There's such test in EEST already https://github.com/ethereum/execution-spec-tests/blob/main/tests/prague/eip7692_eof_v1/eip7069_extcall/test_calls.py#L874 (judging by name only, I didn't read the diff)

chfast commented 2 months ago

Yes, I just need one example locally.

It actually crashes because of the stack overflow. This is because we don't run EEST with Clang nor MSVC debug builds.