ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
864 stars 286 forks source link

evmone exports currentBaseFee on legacy forks #1073

Closed winsvega closed 16 hours ago

winsvega commented 4 days ago

https://github.com/ethereum/execution-spec-tests/pull/968

due to the way pyspec is constructing tests. this return leads to invalid test generation such issue happens:

src/ethereum_test_fixtures/verify_format.py:28: in verify_blockchain_fixture_json
    raise Exception(
E   Exception: Error in generated blockchain test json (tests/frontier/opcodes/test_dup.py::test_dup[fork_Frontier-evm_code_type_LEGACY-blockchain_test-DUP1])[{"type":"extra_forbidden","loc":["baseFeePerGas"],"msg":"Extra inputs are not permitted","input":"0x00","url":"https://errors.pydantic.dev/2.9/v/extra_forbidden"}]

test is created with blockheader having this field on legacy forks.

other transition tools don't report this field on legacy fields.

we think evmone t8n should follow the majority of t8n's