search

ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
841 stars 281 forks source link

Compute `CREATE` address without RLP library #783

Open chfast opened 9 months ago

chfast commented 9 months ago

We want to decouple RLP library (mostly used in testing infrastructure and MPT hashing) from the core EVM state modifications. The CREATE address derivation is the only place where RLP is used. For this we only need to implement RLP encoding for uint64.

See the TODO comment at https://github.com/ethereum/evmone/blob/v0.11.0/test/state/host.cpp#L149.

AbhinavMir commented 7 months ago

Hi @chfast ! Does the draft PR above look right? I looked at how Aleth used to encode JSON objects and bounced off from there to create a rlp_encode_uint64 function.

elijahhampton commented 1 week ago

Looks like the PR for this wasn't accepted and has gone stale. I can pick this up @chfast

chfast commented 1 week ago

Ok, give it a try. For the clarification: any JSON should not be involved.