search

ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
865 stars 287 forks source link

Move TXCREATE and InitcodeTransaction to Osaka #889

Closed gumb0 closed 6 months ago

gumb0 commented 6 months ago

The TXCREATE instruction and EOF InitcodeTransaction have been removed from the EIP-7620 in https://github.com/ethereum/EIPs/pull/8522.

This update moves the implementation of these to the next revision: Osaka.

Requires https://github.com/ethereum/evmc/pull/711

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.50%. Comparing base (642ebda) to head (52a55b9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #889 +/- ## ========================================== + Coverage 98.48% 98.50% +0.01% ========================================== Files 130 130 Lines 15625 15625 ========================================== + Hits 15389 15391 +2 + Misses 236 234 -2 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/889/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [ethereum-tests](https://app.codecov.io/gh/ethereum/evmone/pull/889/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `27.95% <0.00%> (ø)` | | | [ethereum-tests-silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/889/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.69% <0.00%> (ø)` | | | [execution-spec-tests](https://app.codecov.io/gh/ethereum/evmone/pull/889/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.06% <0.00%> (ø)` | | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/889/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `94.35% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ethereum/evmone/pull/889?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/state/state.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/889?src=pr&el=tree&filepath=test%2Fstate%2Fstate.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9zdGF0ZS5jcHA=) | `100.00% <100.00%> (ø)` | | | [...est/unittests/state\_transition\_eof\_create\_test.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/889?src=pr&el=tree&filepath=test%2Funittests%2Fstate_transition_eof_create_test.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvc3RhdGVfdHJhbnNpdGlvbl9lb2ZfY3JlYXRlX3Rlc3QuY3Bw) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/ethereum/evmone/pull/889/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum)
chfast commented 6 months ago

I meged the EVMC upgrade only in #897.

gumb0 commented 6 months ago

This is currently blocked on updating ethereum/tests