chfast
commented
6 months ago Seems no performance regressions:
Zen2, clang-18:
baseline/execute/main/blake2b_huff/empty_mean +0.0013 +0.0013 10 10 10 10
baseline/execute/main/blake2b_huff/8415nulls_mean -0.0105 -0.0105 603 597 603 597
baseline/execute/main/blake2b_shifts/8415nulls_mean -0.0268 -0.0268 5650 5498 5650 5498
baseline/execute/main/sha1_divs/empty_mean -0.0080 -0.0080 42 42 42 42
baseline/execute/main/sha1_divs/5311_mean +0.0010 +0.0010 3335 3338 3335 3338
baseline/execute/main/sha1_shifts/empty_mean -0.0070 -0.0070 22 21 22 21
baseline/execute/main/sha1_shifts/5311_mean -0.0081 -0.0081 1776 1761 1776 1761
baseline/execute/main/snailtracer/benchmark_mean -0.0088 -0.0088 29799 29538 29799 29538
baseline/execute/main/structarray_alloc/nfts_rank_mean -0.0136 -0.0136 396 391 396 391
baseline/execute/main/swap_math/spent_mean -0.0081 -0.0081 2 2 2 2
baseline/execute/main/swap_math/received_mean -0.0133 -0.0133 2 2 2 2
baseline/execute/main/swap_math/insufficient_liquidity_mean -0.0034 -0.0034 1 1 1 1
baseline/execute/main/weierstrudel/1_mean -0.0019 -0.0019 139 139 139 139
baseline/execute/main/weierstrudel/15_mean -0.0119 -0.0119 1387 1370 1387 1370
OVERALL_GEOMEAN -0.0085 -0.0085 0 0 0 0
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #895 +/- ## ========================================== - Coverage 98.50% 98.47% -0.03% ========================================== Files 130 130 Lines 15627 15628 +1 ========================================== - Hits 15393 15390 -3 - Misses 234 238 +4 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/895/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [ethereum-tests](https://app.codecov.io/gh/ethereum/evmone/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `27.95% <66.66%> (+<0.01%)` | :arrow_up: | | [ethereum-tests-silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.69% <66.66%> (+<0.01%)` | :arrow_up: | | [execution-spec-tests](https://app.codecov.io/gh/ethereum/evmone/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.05% <63.63%> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/895/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `94.33% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ethereum/evmone/pull/895?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [lib/evmone/advanced\_analysis.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/895?src=pr&el=tree&filepath=lib%2Fevmone%2Fadvanced_analysis.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-bGliL2V2bW9uZS9hZHZhbmNlZF9hbmFseXNpcy5ocHA=) | `96.29% <100.00%> (ø)` | | | [lib/evmone/baseline.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/895?src=pr&el=tree&filepath=lib%2Fevmone%2Fbaseline.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-bGliL2V2bW9uZS9iYXNlbGluZS5jcHA=) | `100.00% <100.00%> (ø)` | | | [lib/evmone/execution\_state.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/895?src=pr&el=tree&filepath=lib%2Fevmone%2Fexecution_state.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-bGliL2V2bW9uZS9leGVjdXRpb25fc3RhdGUuaHBw) | `96.72% <100.00%> (-0.06%)` | :arrow_down: | | [lib/evmone/instructions.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/895?src=pr&el=tree&filepath=lib%2Fevmone%2Finstructions.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-bGliL2V2bW9uZS9pbnN0cnVjdGlvbnMuaHBw) | `99.36% <100.00%> (-0.64%)` | :arrow_down: |