search

ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
865 stars 287 forks source link

test: Improve EXTCODEHASH test #904

Closed chfast closed 6 months ago

chfast commented 6 months ago

The expected_hash was unused.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.48%. Comparing base (642ebda) to head (409d7f7). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #904 +/- ## ========================================== - Coverage 98.48% 98.48% -0.01% ========================================== Files 130 130 Lines 15625 15622 -3 ========================================== - Hits 15389 15386 -3 Misses 236 236 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/904/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [ethereum-tests](https://app.codecov.io/gh/ethereum/evmone/pull/904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `27.95% <0.00%> (+<0.01%)` | :arrow_up: | | [ethereum-tests-silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.70% <0.00%> (+<0.01%)` | :arrow_up: | | [execution-spec-tests](https://app.codecov.io/gh/ethereum/evmone/pull/904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `19.06% <0.00%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/904/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `94.34% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ethereum/evmone/pull/904?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/unittests/evm\_state\_test.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/904?src=pr&el=tree&filepath=test%2Funittests%2Fevm_state_test.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvZXZtX3N0YXRlX3Rlc3QuY3Bw) | `100.00% <100.00%> (ø)` | |