search

ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
865 stars 287 forks source link

tidy: Avoid returning void #913

Closed chfast closed 6 months ago

chfast commented 6 months ago

Fix clang-tidy check "readability-avoid-return-with-void-value". https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-return-with-void-value.html

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.27%. Comparing base (5a19003) to head (f7dbe41). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #913 +/- ## ========================================== - Coverage 95.33% 95.27% -0.07% ========================================== Files 138 138 Lines 15615 15617 +2 ========================================== - Hits 14887 14879 -8 - Misses 728 738 +10 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/913/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [ethereum_tests](https://app.codecov.io/gh/ethereum/evmone/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `?` | | | [ethereum_tests_silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `18.54% <50.00%> (+<0.01%)` | :arrow_up: | | [execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `18.08% <50.00%> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/913/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `90.37% <50.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ethereum/evmone/pull/913?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/state/mpt.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/913?src=pr&el=tree&filepath=test%2Fstate%2Fmpt.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9tcHQuY3Bw) | `98.18% <100.00%> (+0.01%)` | :arrow_up: | | [test/precompiles\_bench/precompiles\_bench.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/913?src=pr&el=tree&filepath=test%2Fprecompiles_bench%2Fprecompiles_bench.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9wcmVjb21waWxlc19iZW5jaC9wcmVjb21waWxlc19iZW5jaC5jcHA=) | `0.00% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/ethereum/evmone/pull/913/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum)