search

ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
865 stars 287 forks source link

eof: Merge implementations of `compute_[create2|eofcreate]_address` #959

Closed pdobacz closed 4 months ago

pdobacz commented 4 months ago

The two implementations did the exact same thing (maybe they diverged earlier?). At this point it makes sense to have one.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.29%. Comparing base (2ba35a0) to head (76477bc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #959 +/- ## ========================================== - Coverage 94.30% 94.29% -0.01% ========================================== Files 143 143 Lines 16142 16129 -13 ========================================== - Hits 15222 15209 -13 Misses 920 920 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [eof_execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `16.86% <3.57%> (-0.07%)` | :arrow_down: | | [ethereum_tests](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `26.92% <0.00%> (+0.02%)` | :arrow_up: | | [ethereum_tests_silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `18.69% <0.00%> (+0.01%)` | :arrow_up: | | [execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `17.92% <0.00%> (+0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/959/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `89.72% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/ethereum/evmone/pull/959?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/state/host.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/959?src=pr&el=tree&filepath=test%2Fstate%2Fhost.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9ob3N0LmNwcA==) | `100.00% <100.00%> (ø)` | | | [test/state/host.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/959?src=pr&el=tree&filepath=test%2Fstate%2Fhost.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9ob3N0LmhwcA==) | `100.00% <ø> (ø)` | | | [...est/unittests/state\_transition\_eof\_create\_test.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/959?src=pr&el=tree&filepath=test%2Funittests%2Fstate_transition_eof_create_test.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvc3RhdGVfdHJhbnNpdGlvbl9lb2ZfY3JlYXRlX3Rlc3QuY3Bw) | `100.00% <100.00%> (ø)` | |
pdobacz commented 4 months ago

Coverage hiccup because I'm guessing the number of total covered lines decreased? Everything seems to be OK in the report

pdobacz commented 4 months ago

@chfast this is good to go despite the codecov :x: , I haven't missed anything there, did I?