ethereum / evmone

Fast Ethereum Virtual Machine implementation
Apache License 2.0
865 stars 287 forks source link

EIP-7702: Set EOA account code #961

Open gumb0 opened 4 months ago

gumb0 commented 4 months ago

Current status:

Depends on https://github.com/ethereum/evmc/pull/720

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 94.38776% with 22 lines in your changes missing coverage. Please review.

Project coverage is 94.29%. Comparing base (93d11cd) to head (96a40ec).

Files with missing lines Patch % Lines
test/state/transaction.cpp 20.00% 8 Missing :warning:
lib/evmone/instructions.hpp 89.18% 4 Missing :warning:
test/state/errors.hpp 0.00% 4 Missing :warning:
lib/evmone/instructions_calls.cpp 81.25% 3 Missing :warning:
test/state/state.cpp 96.77% 2 Missing :warning:
test/statetest/statetest.hpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #961 +/- ## ======================================== Coverage 94.29% 94.29% ======================================== Files 158 159 +1 Lines 17080 17448 +368 ======================================== + Hits 16105 16452 +347 - Misses 975 996 +21 ``` | [Flag](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [eof_execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `23.29% <15.60%> (-0.24%)` | :arrow_down: | | [ethereum_tests](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `26.12% <11.76%> (-0.38%)` | :arrow_down: | | [ethereum_tests_silkpre](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `18.84% <9.43%> (-0.26%)` | :arrow_down: | | [execution_spec_tests](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `20.75% <35.80%> (+0.53%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/ethereum/evmone/pull/961/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `89.45% <87.72%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/ethereum/evmone/pull/961?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [test/blockchaintest/blockchaintest.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fblockchaintest%2Fblockchaintest.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9ibG9ja2NoYWludGVzdC9ibG9ja2NoYWludGVzdC5jcHA=) | `87.50% <ø> (ø)` | | | [test/blockchaintest/blockchaintest.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fblockchaintest%2Fblockchaintest.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9ibG9ja2NoYWludGVzdC9ibG9ja2NoYWludGVzdC5ocHA=) | `0.00% <ø> (ø)` | | | [test/state/account.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstate%2Faccount.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9hY2NvdW50LmhwcA==) | `100.00% <ø> (ø)` | | | [test/state/host.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstate%2Fhost.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9ob3N0LmNwcA==) | `100.00% <100.00%> (ø)` | | | [test/state/state\_diff.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstate%2Fstate_diff.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS9zdGF0ZV9kaWZmLmhwcA==) | `100.00% <ø> (ø)` | | | [test/state/test\_state.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstate%2Ftest_state.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS90ZXN0X3N0YXRlLmNwcA==) | `100.00% <100.00%> (ø)` | | | [test/state/transaction.hpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstate%2Ftransaction.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZS90cmFuc2FjdGlvbi5ocHA=) | `100.00% <ø> (ø)` | | | [test/statetest/statetest.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstatetest%2Fstatetest.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZXRlc3Qvc3RhdGV0ZXN0LmNwcA==) | `92.85% <100.00%> (+0.54%)` | :arrow_up: | | [test/statetest/statetest\_loader.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Fstatetest%2Fstatetest_loader.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC9zdGF0ZXRlc3Qvc3RhdGV0ZXN0X2xvYWRlci5jcHA=) | `98.33% <100.00%> (+0.17%)` | :arrow_up: | | [test/unittests/evm\_eof\_calls\_test.cpp](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree&filepath=test%2Funittests%2Fevm_eof_calls_test.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-dGVzdC91bml0dGVzdHMvZXZtX2VvZl9jYWxsc190ZXN0LmNwcA==) | `100.00% <100.00%> (ø)` | | | ... and [8 more](https://app.codecov.io/gh/ethereum/evmone/pull/961?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | |
gitguardian[bot] commented 3 months ago

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gumb0 commented 2 months ago

GitGuardian warning is clearly a false positive, but also it will go away after devnet3 with this change https://github.com/ethereum/EIPs/pull/8845