eth: add eth_fillTransaction, fix result of eth_signTransaction

ethereum / execution-apis

Collection of APIs provided by Ethereum execution layer clients

Creative Commons Zero v1.0 Universal

908 stars 352 forks source link

eth: add eth_fillTransaction, fix result of eth_signTransaction #512

Open s1na opened 6 months ago

s1na commented 6 months ago

Fixes https://github.com/ethereum/execution-apis/issues/508

While adding spec for eth_fillTransaction I noticed that the spec for eth_signTransaction deviates from the geth implementation. I'm not sure yet how other clients implement this.

s1na commented 5 months ago

I've updated the PR with support for generation and verification of blob sidecars. The proposal is as follows:

If the transaction arguments contain a non-empty list of blobs, then, fillTransaction will:

Fill in proofs, commitments if they are not provided
Verify proofs, commitments if they are provided

And later verify or compute blob hashes from those commitments.