search

ethereum / execution-apis

Collection of APIs provided by Ethereum execution layer clients
Creative Commons Zero v1.0 Universal
908 stars 352 forks source link

Add EIP-7251 to Prague #532

Closed ensi321 closed 3 months ago

ensi321 commented 3 months ago

Since EIP-7251 is included into Pectra fork. We should consider including it in the Engine API spec.

One of the features of EIP-7251 is to integrate EIP-7002 to support execution layer triggerable partial withdrawals via ExitV1.

This PR adds amount to ExitV1 such that it supports partial withdrawals on top of full exits.

A point of discussion is the use of word exit. Originally EIP-7002 only considers full withdrawals (exits). With the newly added responsibility, one may consider renaming exit to executionLayerWithdraw for more precise description and to be distinguishable from the current withdrawal mechanism (consensus layer triggered).

mkalinin commented 3 months ago

Looks good to me! 👍 I’d like to see the corresponding change to the EIP-7002 in the first place, or at least a PR with the change

lightclient commented 3 months ago

Here is the PR to the EIP: https://github.com/ethereum/EIPs/pull/8406

mkalinin commented 3 months ago

One thing that we’ll have to do is to rename ExitV1 to SomethingV1 if there is a decision to do the renaming in the EIP. I didn't want this PR to be held by the naming issue — can do the renaming separately