engine: Extend payload bodies with deposit and withdrawal requests

ethereum / execution-apis

Collection of APIs provided by Ethereum execution layer clients

Creative Commons Zero v1.0 Universal

908 stars 352 forks source link

engine: Extend payload bodies with deposit and withdrawal requests #545

Closed mkalinin closed 2 months ago

mkalinin commented 2 months ago

Introduces ExecutionPayloadBodyV2 to accommodate depositRequests and withdrawalRequests added to the payload body in Prague, this entails adding new engine_getPayloadBodiesByRangeV2 and engine_getPayloadBodiesByHashV2 methods. This PR also contains a few naming adjustments in the examples part of the schema.

realbigsean commented 2 months ago

Was talking to @mkalinin about this today. Looks like both V1 and V2 are backwards compatible and we won't want to deal with switching endpoints at the fork since they might be used during syncing for example. It probably makes sense to just extend V1.

james-prysm commented 1 month ago

prysm implemented v2 but not that big of a deal to go back if there's consensus on that

MarekM25 commented 3 weeks ago

Was talking to @mkalinin about this today. Looks like both V1 and V2 are backwards compatible and we won't want to deal with switching endpoints at the fork since they might be used during syncing for example. It probably makes sense to just extend V1.

I agree, I think it will be better to extend V1. We added V2 methods for now