search

ethereum / execution-apis

Collection of APIs provided by Ethereum execution layer clients
Creative Commons Zero v1.0 Universal
908 stars 352 forks source link

engine: align WithdrawalRequestV1 with EIP-7002 and consensus spec #549

Closed nflaig closed 1 month ago

nflaig commented 2 months ago

There is an inconsistency between the withdrawal request defined in EIP-7002 (see validator_pubkey field and related PR), the consensus spec (see ExecutionLayerWithdrawalRequest), and the execution api.

This PR align the execution api spec WithdrawalRequestV1 with the other specs.

Most ELs currently return it as validatorPublicKey with the exception of Besu which uses validatorPubKey

nflaig commented 1 month ago

Do we wanna include this for devnet-1? Might need more visibility on it first, I am not that familiar how you do this on the execution api side but maybe could bring this up in discord and see if there is any opposition to the change