search

ethereum / execution-spec-tests

A Python framework and collection of test cases to generate test vectors for Ethereum execution clients
https://ethereum.github.io/execution-spec-tests
MIT License
88 stars 62 forks source link

feat(consume): add client config files to EEST #609

Open spencer-tb opened 3 weeks ago

spencer-tb commented 3 weeks ago

Consume client configs within EEST

The future of the consume suite is looking bright but there are still a few more things to clean up on our end. Following this sentiment I'd like for us to only require changes within EEST when updating the simulators.

Currently, if we want to change the client branch being tested we need update the client config file within hive: configs/prague.yaml etc.

I'm proposing that we create and maintain these configs directly within EEST, such that we can pass these to hive in an equivalent fashion: ./hive ... --client-file configs/prague.yaml.

Other ideas

If we want to make hive changes obsolete for consume rlp/engine completely, we'd also require a method that prevents us from having to maintain the conusme Dockerfiles within hive. See the following for an example: https://github.com/danceratopz/hive/blob/verkle-transition-prague/simulators/ethereum/eest-block-rlp/Dockerfile

To resolve this we could additiionally more further config files, that target the EEST branch & release artifacts used within the simulator Dockerfiles.

spencer-tb commented 3 weeks ago

@marioevz, @danceratopz - any thoughts on this? do you agree with this sentiment?