Closed danceratopz closed 1 week ago
Tested with this Github Actions Workflow: https://github.com/danceratopz/execution-spec-tests/actions/runs/9500351128/job/26183213458
Example artifact ("stable"): https://github.com/danceratopz/execution-spec-tests/actions/runs/9500351128/artifacts/1598139447
which has the fixtures.properties
:
[fixtures]
timestamp = 2024-06-13T13:16:17.589569
build = stable
ref = refs/heads/feat/directly-create-release-tarball
commit = 097e5edc73b649c9eac82ec3dfbbe08ce31628e9
command_line_args = fill -n auto --evm-bin=evm --output=fixtures_stable.tar.gz --build-name stable
[packages]
pytest = 7.4.4
pluggy = 1.5.0
[plugins]
html = 4.1.1
metadata = 3.1.1
xdist = 3.6.1
[tools]
t8n = evm version 1.14.6-unstable-86150af2-20240612
solc = 0.8.21+commit.d9974bed.Linux.gpp
[environment]
python = 3.11.9
platform = Linux-6.5.0-1021-azure-x86_64-with-glibc2.35
ci = true
Renamed the "properties" file from fixtures.properties
to fixtures.ini
: We're using the python standard library's configparser
module to write this file which creates a file in the .ini file format (this output is not valid .properties format due to the sections, e.g., [fixtures]
).
This file is mainly intended for internal EEST use (consume
) but might be useful to other people. Ini format should be readable by most languages, but feel free to change it to JSON (@marioevz, @spencer-tb).
@marioevz I've noticed that this might have changed the layout of the release artifact - inside the .tar.gz
file one now has the intermediate dir with a suffix, i.e. fixtures_eip7692
dir, instead of just fixtures
. Was this change intended?
Unless I've misconfigured sth on my end, you can take a look at such release here - fixtures_eip7692
inside. Compare with a previous one - fixtures
inside.
@pdobacz I think you're right, let me dig into the changes and see how we can fix it, thanks for pointing this out!
🗒️ Description
Adds some release-specific requirements directly to
fill
command:If
--output=fixtures.tgz
is specified, then additionally create the tarball. From the help:Always writes a fixtures build properties file
fixtures.ini
to the output directory. A build name may be specified via--build-name
:Uses 1. and 2. in
.github/actions/build-fixtures/action.yaml
.Example fixture build properties file (
--build-name=eip7692
):🔗 Related Issues
None
✅ Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.