new(tests): EOF - EIP-3540: test all opcodes in valid code section

ethereum / execution-spec-tests

A Python framework and collection of test cases to generate test vectors for Ethereum execution clients

https://ethereum.github.io/execution-spec-tests

MIT License

105 stars 72 forks source link

new(tests): EOF - EIP-3540: test all opcodes in valid code section #634

Closed winsvega closed 3 months ago

winsvega commented 3 months ago

🗒️ Description

Put every instruction with valid stack / data in between a valid eof code section

🔗 Related Issues

✅ Checklist

[x] All: Set appropriate labels for the changes.
[x] All: Considered squashing commits to improve commit history.
[ ] All: Added an entry to CHANGELOG.md.
[x] All: Considered updating the online docs in the ./docs/ directory.
[x] Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
[x] Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
[x] Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

winsvega commented 3 months ago

Hi, I think all tests can benefit from UndefinedOpcodes enum. Also I think Unrechable instruction exception if for another test case. here we just check that if opcode is valid and in eof then no exception happens. (the only exception here is retf) I applied your commit also

the tox error:

        File "/tmp/pip-build-env-agpk7lji/overlay/lib/python3.12/site-packages/setuptools/_distutils/dist.py", line 862, in get_command_obj
 cmd_obj = self.command_obj[command] = klass(self)
                                                ^^^^^^^^^^^
      TypeError: 'NoneType' object is not callable
      [end of output]

is this related to my code or a global issue?

marioevz commented 3 months ago

is this related to my code or a global issue?

Global issue, I'll help rebase because I just merged a big PR :+1: