ethereum / execution-spec-tests

A Python framework and collection of test cases to generate test vectors for Ethereum execution clients
https://ethereum.github.io/execution-spec-tests
MIT License
105 stars 72 forks source link

new(tests): EIP-7251: Increase the MAX_EFFECTIVE_BALANCE (EL Consolidations) #642

Closed marioevz closed 2 months ago

marioevz commented 3 months ago

🗒️ Description

Implements tests for EIP-7251

🔗 Related Issues

606

✅ Checklist

marioevz commented 3 months ago
* These might exist here already but could we do recursive consolidation requests? My guess is where we use the same target public key.

I don't understand how could they be recursive since the contracts cannot do calls themselves to other contracts, do you mean on a loop?

marioevz commented 3 months ago

Added a modification that ensures the test keeps producing blocks until the consolidation/withdrawal requests queues are exhausted, in order to properly validate that the invalid requests are not included in a future block. This is done to all test cases.

spencer-tb commented 2 months ago
* These might exist here already but could we do recursive consolidation requests? My guess is where we use the same target public key.

I don't understand how could they be recursive since the contracts cannot do calls themselves to other contracts, do you mean on a loop?

Yeah you are right, they can't be recursive!