ethereum / execution-spec-tests

A Python framework and collection of test cases to generate test vectors for Ethereum execution clients
https://ethereum.github.io/execution-spec-tests
MIT License
105 stars 72 forks source link

new(tests): EOF - EIP-7620: RETURNCONTRACT validation tests #647

Closed gumb0 closed 2 months ago

gumb0 commented 3 months ago

πŸ—’οΈ Description

This migrates RETURNCONTRACT validation tests from ethereum/tests.

Note: according to the latest spec these cases are valid only for "initcode" containers, and next step would be to support initcontainer flag in test fixtures - see the branch https://github.com/ipsilon/execution-spec-tests/tree/eof-returncontract-initcode

πŸ”— Related Issues

βœ… Checklist

winsvega commented 3 months ago

https://github.com/ethereum/execution-spec-tests/pull/657

but I still can't fill the tests. ah is it because test generation fails because it requires specific evmone branch? the script rely that the tests are fillable with latest evmone

this is my log https://github.com/ethereum/execution-spec-tests/actions/runs/9734953340/job/26863601732?pr=656

marioevz commented 2 months ago

Hey @gumb0 could you rebase and push to see if that fixes the CI please?

marioevz commented 2 months ago

Also coverage fix is now merged in main, so that should be removed from this PR on rebase and we should be good to merge.

chfast commented 2 months ago

Any fixes needed here?

chfast commented 2 months ago

The latest evmone master branch fails to generate this tests.

I believe this is fixed now.

winsvega commented 2 months ago

ah, still missed the coverage check on evmone native tools. well I work on the script a little more