search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
838 stars 236 forks source link

EELS t8n return empty exception strings #1021

Open winsvega opened 2 weeks ago

winsvega commented 2 weeks ago 

{'body': '0xf84df84b800a82cf0780808025a00372ba5e45d0a0e636f7e32ffca16f97a2f3e4e930b6584b7b114ab3aa191b4fa04afdfcd2bc179e25c7aa74cb991a08f0ae6c01541a36f700be25c6f4c39bc098', 'alloc': {'0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b': {'balance': '0x3635c9adc5dea00000'}}, 'result': {'stateRoot': '0x70c42824108fafccadbfce71e6e22660c4fad89be18be324cd15ef351969a8c8', 'txRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'receiptsRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'withdrawalsRoot': '0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421', 'logsHash': '0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347', 'logsBloom': '0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000', 'gasUsed': '0x0', 'currentDifficulty': None, 'currentBaseFee': '0x7', 'rejected': [{'index': 0, 'error': 'Failed transaction: '}], 'receipts': []}}

message Failed transaction: is not sufficient enough to match exception code

the exception string is empty in line src/ethereum_spec_tools/evm_tools/t8n/init.py

this probably goes to EELS repo https://github.com/ethereum/execution-spec-tests/issues/881

command:

uv run fill "tests/cancun/eip4844_blobs/test_blob_txs.py::test_insufficient_balance_blob_tx[fork_Cancun-blockchain_test--exact_balance_minus_1-tx_max_fee_per_blob_gas_1-no_calldata-tx_value_1-tx_max_priority_fee_per_gas_0-tx_max_fee_per_gas_7-no_access_list]"

Note to Implementer

Once all the specific exception types are being thrown correctly, make sure to update the test loader to take advantage:

https://github.com/ethereum/execution-specs/blob/420f7a8327139d69b4493bb6a51526706f0e85c9/tests/helpers/load_state_tests.py#L72-L74

SamWilsn commented 2 weeks ago

List of exceptions we should raise: https://github.com/ethereum/execution-spec-tests/blob/main/src/ethereum_test_exceptions/exceptions.py