ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
869 stars 240 forks source link

Exception strings: `TYPE_NOT_SUPPORTED` #1024

Closed SamWilsn closed 3 weeks ago

SamWilsn commented 1 month ago

What was wrong?

Related to Issue #1021

How was it (partially) fixed?

Adding a new exception type to match TransactionException.TYPE_NOT_SUPPORTED.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 72.38095% with 29 lines in your changes missing coverage. Please review.

Project coverage is 83.59%. Comparing base (da1e112) to head (66f2dac). Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
src/ethereum/arrow_glacier/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/cancun/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/gray_glacier/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/london/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/paris/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/shanghai/exceptions.py 75.00% 2 Missing :warning:
src/ethereum/arrow_glacier/fork.py 50.00% 1 Missing :warning:
src/ethereum/arrow_glacier/transactions.py 50.00% 1 Missing :warning:
src/ethereum/byzantium/fork.py 50.00% 1 Missing :warning:
src/ethereum/cancun/transactions.py 50.00% 1 Missing :warning:
... and 13 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1024 +/- ## ========================================== - Coverage 83.59% 83.59% -0.01% ========================================== Files 644 650 +6 Lines 36123 36157 +34 ========================================== + Hits 30198 30226 +28 - Misses 5925 5931 +6 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/1024/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/1024/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `83.59% <72.38%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.