search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
810 stars 225 forks source link

Shanghai bug fix and tests #761

Closed gurukamath closed 1 year ago

gurukamath commented 1 year ago

(closes #753 )

What was wrong?

Currently, the warmcoinbase is not applied to LegacyTransaction in Shanghai

How was it fixed?

Fixes the warmcoinbase bug. Additionally, the shanghai tests are extended to include all available tests

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.08 :tada:

Comparison is base (37a8f89) 85.11% compared to head (41a87f2) 87.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #761 +/- ## ========================================== + Coverage 85.11% 87.20% +2.08% ========================================== Files 570 570 Lines 31557 31557 ========================================== + Hits 26860 27519 +659 + Misses 4697 4038 -659 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `87.20% <100.00%> (+2.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/ethereum/execution-specs/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [src/ethereum/shanghai/fork.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL3NoYW5naGFpL2ZvcmsucHk=) | `96.41% <100.00%> (+13.00%)` | :arrow_up: | ... and [28 files with indirect coverage changes](https://app.codecov.io/gh/ethereum/execution-specs/pull/761/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.