search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

Automatically detect expected exceptions #767

Closed gurukamath closed 1 year ago

gurukamath commented 1 year ago

(closes #760 )

What was wrong?

The tests that throw exceptions were currently hardcoded in the testing framework.

Related to Issue #760

How was it fixed?

Automatically detect which test fixtures have the expectException fields. This PR also does some refactoring of the testing framework, making it more streamlined and a bit more efficient.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.05 :tada:

Comparison is base (a620b0a) 74.01% compared to head (cf9075f) 74.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #767 +/- ## ========================================== + Coverage 74.01% 74.06% +0.05% ========================================== Files 570 570 Lines 31557 31557 ========================================== + Hits 23356 23372 +16 + Misses 8201 8185 -16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `74.06% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/ethereum/execution-specs/pull/767/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.