Closed winsvega closed 1 year ago
Finally, I would add additional checks in the tests to make sure that the tx_hash
, gas_used
etc in the receipt is calculated properly. You could add the following checks at the end of the t8n_tool_test
function in the tests/evm_tools/test_t8n.py
module.
if "receipts" in data["result"]:
assert len(json_result["receipts"]) == len(data["result"]["receipts"])
for t8n_receipt, expected_receipt in zip(
json_result["receipts"], data["result"]["receipts"]
):
assert t8n_receipt["gasUsed"] == expected_receipt["gasUsed"]
assert (
t8n_receipt["transactionHash"]
== expected_receipt["transactionHash"]
)
assert t8n_receipt["blockHash"] == expected_receipt["blockHash"]
Patch and project coverage have no change.
Comparison is base (
c90ccbe
) 74.06% compared to head (4923db6
) 74.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Finally, I would add additional checks in the tests to make sure that the
tx_hash
,gas_used
etc in the receipt is calculated properly. You could add the following checks at the end of thet8n_tool_test
function in thetests/evm_tools/test_t8n.py
module.
I just missed this part in the review. Could you please add these checks in the tests?
Actually I did. But it got lost it seems.
here is my attempt to introduce t8n receipt information. I need at least those 3 fields.