search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

t8n:: move env to a separate file #772

Closed winsvega closed 1 year ago

winsvega commented 1 year ago

To get better with python I start with refactoring the existing code. I first try to make it better without breaking existing functionality.

gurukamath commented 1 year ago

The code needs to be formatted but other than that, it looks good to me. To identify the issues with the code formatting, you could run the isort, black, flake8 and mypy commands from tox.ini

winsvega commented 1 year ago

I run tox -e py3 but how can I make it change write the corrections instead of reporting?

petertdavies commented 1 year ago

I run tox -e py3 but how can I make it change write the corrections instead of reporting?

You need to run isort src and black src manually. tox provides the --check flag which doesn't rewrite the file. You may need to pip install black and pip install isort, if they aren't already installed on your system or in you venv.

SamWilsn commented 1 year ago

Our CONTRIBUTING.md has the full details.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.05 :tada:

Comparison is base (aadc2a4) 74.01% compared to head (617171e) 74.06%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #772 +/- ## ========================================== + Coverage 74.01% 74.06% +0.05% ========================================== Files 570 570 Lines 31557 31557 ========================================== + Hits 23356 23372 +16 + Misses 8201 8185 -16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `74.06% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/ethereum/execution-specs/pull/772/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.