ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
810 stars 225 forks source link

Handle create collisions #794

Closed petertdavies closed 1 year ago

petertdavies commented 1 year ago

What was wrong?

Some tests involving an obscure edgecase were not supported.

How was it fixed?

Add support for the edgecase to the specs and optimized state.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 65.38% and project coverage change: -0.03 :warning:

Comparison is base (aa48fa7) 74.06% compared to head (d02b2fa) 74.03%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #794 +/- ## ========================================== - Coverage 74.06% 74.03% -0.03% ========================================== Files 570 570 Lines 31557 31653 +96 ========================================== + Hits 23372 23435 +63 - Misses 8185 8218 +33 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `74.03% <65.38%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [src/ethereum/arrow\_glacier/state.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2Fycm93X2dsYWNpZXIvc3RhdGUucHk=) | `0.00% <0.00%> (ø)` | | | [src/ethereum/arrow\_glacier/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2Fycm93X2dsYWNpZXIvdm0vaW50ZXJwcmV0ZXIucHk=) | `0.00% <0.00%> (ø)` | | | [src/ethereum/constantinople/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2NvbnN0YW50aW5vcGxlL3ZtL2ludGVycHJldGVyLnB5) | `98.98% <ø> (ø)` | | | [src/ethereum/gray\_glacier/state.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2dyYXlfZ2xhY2llci9zdGF0ZS5weQ==) | `0.00% <0.00%> (ø)` | | | [src/ethereum/gray\_glacier/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2dyYXlfZ2xhY2llci92bS9pbnRlcnByZXRlci5weQ==) | `0.00% <0.00%> (ø)` | | | [src/ethereum/muir\_glacier/state.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL211aXJfZ2xhY2llci9zdGF0ZS5weQ==) | `0.00% <0.00%> (ø)` | | | [src/ethereum/muir\_glacier/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL211aXJfZ2xhY2llci92bS9pbnRlcnByZXRlci5weQ==) | `0.00% <0.00%> (ø)` | | | [src/ethereum/berlin/state.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2Jlcmxpbi9zdGF0ZS5weQ==) | `98.41% <100.00%> (+0.13%)` | :arrow_up: | | [src/ethereum/berlin/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2Jlcmxpbi92bS9pbnRlcnByZXRlci5weQ==) | `99.00% <100.00%> (+0.01%)` | :arrow_up: | | [src/ethereum/byzantium/vm/interpreter.py](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#diff-c3JjL2V0aGVyZXVtL2J5emFudGl1bS92bS9pbnRlcnByZXRlci5weQ==) | `98.98% <100.00%> (+0.01%)` | :arrow_up: | | ... and [12 more](https://app.codecov.io/gh/ethereum/execution-specs/pull/794?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.