search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

add EIP 6780: only SELFDESTRUCT in same transaction #819

Closed gballet closed 7 months ago

gballet commented 1 year ago

This is my first shot at implementing EIP 6780 in EELS. I'm no Python expert, so this will probably require an extra cautious look-over.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 1 year ago

Codecov Report

Attention: 2214 lines in your changes are missing coverage. Please review.

Comparison is base (bf47143) 69.96% compared to head (85cc3e5) 69.64%. Report is 33 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 259 Missing :warning:
src/ethereum/cancun/vm/instructions/system.py 0.00% 207 Missing :warning:
src/ethereum/cancun/vm/instructions/environment.py 0.00% 167 Missing :warning:
src/ethereum/cancun/vm/instructions/__init__.py 0.00% 164 Missing :warning:
src/ethereum/cancun/state.py 0.00% 149 Missing :warning:
src/ethereum/cancun/vm/gas.py 0.00% 117 Missing :warning:
src/ethereum/cancun/vm/interpreter.py 0.00% 112 Missing :warning:
src/ethereum/cancun/vm/instructions/arithmetic.py 0.00% 109 Missing :warning:
src/ethereum/cancun/vm/instructions/stack.py 0.00% 98 Missing :warning:
src/ethereum/cancun/vm/__init__.py 0.00% 79 Missing :warning:
... and 37 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## forks/cancun #819 +/- ## ================================================ - Coverage 69.96% 69.64% -0.32% ================================================ Files 610 611 +1 Lines 34295 34898 +603 ================================================ + Hits 23993 24306 +313 - Misses 10302 10592 +290 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/819/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/819/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `69.64% <12.97%> (-0.32%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gurukamath commented 8 months ago

@SamWilsn @petertdavies Have updated the implementation