search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
809 stars 223 forks source link

chore: bump required minimum version of coincurve #827

Closed danceratopz closed 10 months ago

danceratopz commented 10 months ago

What was wrong?

ethereum/execution-spec-tests installs the ethereum package provided by execution-specs as a dependency. Both execution-spec-tests and execution-specs require coincurve and currently require >=17,<18.

We'd like to upgrade the required minimum major version of coincurve from 17 to 18 in order to get full Python 3.11 support (https://github.com/ethereum/execution-spec-tests/pull/280). This simplifies installation of execution-test-specs on macOS cf https://github.com/ethereum/execution-spec-tests/issues/274.

Before we can do that, we need execution-specs to upgrade first :-)

How was it fixed?

image

Cute Animal Picture

image "Psst, plz upgrade to coincurve 18!"

codecov-commenter commented 10 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a592a8) 74.06% compared to head (198893e) 74.06%. Report is 10 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #827 +/- ## ======================================= Coverage 74.06% 74.06% ======================================= Files 571 571 Lines 31735 31735 ======================================= Hits 23503 23503 Misses 8232 8232 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/827/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/827/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `74.06% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.