ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

Implement EIP-5656 for Cancun #851

Closed gurukamath closed 8 months ago

gurukamath commented 11 months ago

What was wrong?

EIP-5656, which is slated for Cancun, is not currently implemented in the specs.

How was it fixed?

Implemented EIP-5656

codecov-commenter commented 10 months ago

Codecov Report

Attention: 2208 lines in your changes are missing coverage. Please review.

Comparison is base (673ccec) 69.91% compared to head (4eaed5f) 69.93%. Report is 53 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 225 Missing :warning:
src/ethereum/cancun/vm/instructions/system.py 0.00% 208 Missing :warning:
src/ethereum/cancun/vm/instructions/__init__.py 0.00% 160 Missing :warning:
src/ethereum/cancun/vm/instructions/environment.py 0.00% 143 Missing :warning:
src/ethereum/cancun/state.py 0.00% 126 Missing :warning:
src/ethereum/cancun/vm/instructions/arithmetic.py 0.00% 109 Missing :warning:
src/ethereum/cancun/vm/interpreter.py 0.00% 108 Missing :warning:
src/ethereum/cancun/vm/gas.py 0.00% 97 Missing :warning:
src/ethereum/cancun/vm/instructions/stack.py 0.00% 94 Missing :warning:
src/ethereum/cancun/vm/__init__.py 0.00% 76 Missing :warning:
... and 55 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## forks/cancun #851 +/- ## ================================================ + Coverage 69.91% 69.93% +0.01% ================================================ Files 609 610 +1 Lines 33980 34309 +329 ================================================ + Hits 23758 23993 +235 - Misses 10222 10316 +94 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/851/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/851/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `69.93% <26.12%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.