Ban post merge empty accounts in tests

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.

Creative Commons Zero v1.0 Universal

832 stars 234 forks source link

Open petertdavies opened 10 months ago

petertdavies commented 10 months ago

This PR bans post merge empty accounts in tests in preparation for EIP-7523. Any test that contains such accounts will fail during loading.

Currently a large number of tests fail this check, they need to be removed. Once tests have been fixed this can be made non-draft and merged.

Put a link to a cute animal picture inside the parenthesis-->

SamWilsn commented 6 months ago

My bad for not reviewing this sooner! Is this still in a good state to go through?

petertdavies commented 6 months ago

My bad for not reviewing this sooner! Is this still in a good state to go through?

Unfortunately, I think there are some Cancun related tests with empty accounts in them.

SamWilsn commented 6 months ago

Alright, ping me on Discord when this is ready to go!