search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

Implement EIP-4788 for Cancun #856

Closed gurukamath closed 8 months ago

gurukamath commented 9 months ago

What was wrong?

EIP-4788, which is slated for Cancun, is not currently implemented in the specs.

How was it fixed?

Implemented EIP-4788

codecov-commenter commented 9 months ago

Codecov Report

Attention: 2110 lines in your changes are missing coverage. Please review.

Comparison is base (bf47143) 69.96% compared to head (824c0b0) 69.83%. Report is 23 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 234 Missing :warning:
src/ethereum/cancun/vm/instructions/system.py 0.00% 207 Missing :warning:
src/ethereum/cancun/vm/instructions/__init__.py 0.00% 162 Missing :warning:
src/ethereum/cancun/vm/instructions/environment.py 0.00% 153 Missing :warning:
src/ethereum/cancun/state.py 0.00% 149 Missing :warning:
src/ethereum/cancun/vm/interpreter.py 0.00% 112 Missing :warning:
src/ethereum/cancun/vm/instructions/arithmetic.py 0.00% 109 Missing :warning:
src/ethereum/cancun/vm/instructions/stack.py 0.00% 98 Missing :warning:
src/ethereum/cancun/vm/gas.py 0.00% 97 Missing :warning:
src/ethereum/cancun/vm/__init__.py 0.00% 77 Missing :warning:
... and 35 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## forks/cancun #856 +/- ## ================================================ - Coverage 69.96% 69.83% -0.13% ================================================ Files 610 610 Lines 34295 34771 +476 ================================================ + Hits 23993 24283 +290 - Misses 10302 10488 +186 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/856/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/856/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `69.83% <12.70%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gurukamath commented 8 months ago

Rebased the PR on the latest forks/cancun