search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
832 stars 234 forks source link

Update pending-opcodes.md (DATA*, RETURNDATALOAD, EXCHANGE) #868

Closed pdobacz closed 6 months ago

pdobacz commented 8 months ago

What was wrong?

Related to Issue https://github.com/ipsilon/eof/issues/43. Two opcodes proposed for EOF are in conflict (EXCHANGE and DATALOAD)

Also, EXCHANGE and RETURNDATALOAD proposed by Mega-EOF spec and their respective EIPs were missing, so adding them in as well.

Various EOF-related opcodes were out-of-date in the proposed-opcodes.md.

How was it fixed?

Conflict resolved by moving all DATA* opcodes to the currently empty D section (https://github.com/ipsilon/eof/pull/46).

EXCHANGE and RETURNDATALOAD added,

proposed-opcodes.md updated to match pending-opcodes.md

gumb0 commented 8 months ago

Please update also proposed-opcodes.md

gumb0 commented 8 months ago

Also add EXCHANGE and RETURNDATALOAD.

pdobacz commented 8 months ago

@gumb0

Please update also proposed-opcodes.md

Also add EXCHANGE and RETURNDATALOAD.

Done & done, please double check

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (559ba54) 74.11% compared to head (702845e) 74.11%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #868 +/- ## ======================================= Coverage 74.11% 74.11% ======================================= Files 572 572 Lines 32411 32411 ======================================= Hits 24022 24022 Misses 8389 8389 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/868/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/868/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `74.11% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.