ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
808 stars 222 forks source link

Rename `gas_fee` to `max_gas_fee` #886

Closed gurukamath closed 4 months ago

gurukamath commented 4 months ago

What was wrong?

Post London, the gas_fee calculated in fork.py in in fact the max gas that can be paid in the transaction. The variable is renamed accordingly.

Related to Issue #877

How was it fixed?

Renamed the relevant variable.

Cute Animal Picture

iceland-1979445_640

codecov-commenter commented 4 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (9ca885c) 74.12% compared to head (30695b3) 74.12%.

Files Patch % Lines
src/ethereum/arrow_glacier/fork.py 0.00% 3 Missing :warning:
src/ethereum/gray_glacier/fork.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #886 +/- ## ======================================= Coverage 74.12% 74.12% ======================================= Files 572 572 Lines 32419 32419 ======================================= Hits 24030 24030 Misses 8389 8389 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/886/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/886/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `74.12% <60.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.