search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
808 stars 222 forks source link

Don't swallow exceptions in T8N #892

Closed petertdavies closed 4 months ago

petertdavies commented 4 months ago

What was wrong?

T8N's apply_body() function was catching Exception rather than InvalidBlock, resulting exceptions being silently swallowed.

How was it fixed?

Catch InvalidBlock instead.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.12%. Comparing base (2743979) to head (029c968).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #892 +/- ## ======================================= Coverage 74.12% 74.12% ======================================= Files 572 572 Lines 32419 32419 ======================================= Hits 24030 24030 Misses 8389 8389 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/892/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/892/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `74.12% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.