search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
808 stars 222 forks source link

Cancun fixes #893

Closed gurukamath closed 4 months ago

gurukamath commented 4 months ago

What was wrong?

  1. Cancun spec does not handle undeployed beacon roots contract properly.
  2. blob_versioned_hashes are constant and need to be part of the Environment class instead of the Message class.

How was it fixed?

  1. Delete touched beacon roots contract at the end of the system message call
  2. Move blob_versioned_hashes

Cute Animal Picture

cute dog

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 69.64%. Comparing base (bf47143) to head (8b72f21). Report is 39 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 8 Missing :warning:
src/ethereum/cancun/state.py 0.00% 5 Missing :warning:
src/ethereum/cancun/vm/instructions/environment.py 0.00% 2 Missing :warning:
src/ethereum/cancun/utils/message.py 0.00% 1 Missing :warning:
src/ethereum/cancun/vm/__init__.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## forks/cancun #893 +/- ## ================================================ - Coverage 69.96% 69.64% -0.32% ================================================ Files 610 611 +1 Lines 34295 34901 +606 ================================================ + Hits 23993 24306 +313 - Misses 10302 10595 +293 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/893/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `69.64% <0.00%> (-0.32%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.