search

ethereum / execution-specs

Specification for the Execution Layer. Tracking network upgrades.
Creative Commons Zero v1.0 Universal
808 stars 222 forks source link

Refactor fixture loader #900

Closed gurukamath closed 3 months ago

gurukamath commented 3 months ago

(closes #878 )

What was wrong?

Fixture loader was starting to get bloated and needed to be re-factored.

Related to Issue #878

How was it fixed?

Create separate data classes for loading fork code (ForkLoad), json fixture loader (Load) and json transaction loader (TransactionLoad)

Cute Animal Picture

Library - 1 of 1

gurukamath commented 3 months ago

Completed the updates to the PR based on the review and rebased it on latest forks/cancun.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.64%. Comparing base (bf47143) to head (2b25d07). Report is 51 commits behind head on forks/cancun.

Files Patch % Lines
src/ethereum/cancun/fork.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## forks/cancun #900 +/- ## ================================================ - Coverage 69.96% 69.64% -0.32% ================================================ Files 610 611 +1 Lines 34295 34902 +607 ================================================ + Hits 23993 24306 +313 - Misses 10302 10596 +294 ``` | [Flag](https://app.codecov.io/gh/ethereum/execution-specs/pull/900/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ethereum/execution-specs/pull/900/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum) | `69.64% <66.66%> (-0.32%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ethereum#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.